feat: [IOBP-514] Move authorization creation request upon payment method selection #5419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OBP-514-effettuare-chiamata-di-new-transaction-subito-dopo-che-il-metodo-viene-selezionato
pagopa-github-bot
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5419 +/- ##
==========================================
- Coverage 47.45% 47.43% -0.03%
==========================================
Files 1603 1603
Lines 33618 33637 +19
Branches 8211 8219 +8
==========================================
+ Hits 15953 15955 +2
- Misses 17607 17624 +17
Partials 58 58
Continue to review full report in Codecov by Sentry.
|
mastro993
force-pushed
the
IOBP-514-effettuare-chiamata-di-new-transaction-subito-dopo-che-il-metodo-viene-selezionato
branch
from
5a9eee8 to
a067827
Compare
…ction-subito-dopo-che-il-metodo-viene-selezionato
…ction-subito-dopo-che-il-metodo-viene-selezionato
…ction-subito-dopo-che-il-metodo-viene-selezionato
…ction-subito-dopo-che-il-metodo-viene-selezionato
Hantex9
requested changes
Jan 23, 2024
…ction-subito-dopo-che-il-metodo-viene-selezionato
…ction-subito-dopo-che-il-metodo-viene-selezionato
…ction-subito-dopo-che-il-metodo-viene-selezionato
mastro993
deleted the
IOBP-514-effettuare-chiamata-di-new-transaction-subito-dopo-che-il-metodo-viene-selezionato
branch
mastro993
added a commit
that referenced
this pull request
Jan 25, 2024
…uest (#5423) Depends on #5419 ## Short description This PR add the handling of payment dismissal after payment authorization request ## List of changes proposed in this pull request - Added `onDismiss` in `useWalletPaymentAuthorizationModal` hook - Added outcome screen navigation on authorization dismissal ## How to test Start a new payment flow from **Profile > Playgrounds > New Wallet > Payment**, dismiss the authorization webview in the last step and check that the payment is correctly cancelled. ## Previews https://github.com/pagopa/io-app/assets/6160324/09a9ee38-3134-4053-8b4b-e5b6aa08b6ee --------- Co-authored-by: Alessandro Izzo <[email protected]> Co-authored-by: Alessandro Izzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR moves the transaction creation request from the payment summary screen (
WalletPaymentConfirmScreen) to the payment method selection (WalletPaymentPickMethodScreen), after the payment method selection.List of changes proposed in this pull request
walletPaymentCreateTransactionaction to accept anonSuccesscallbackwalletPaymentCreateTransactiondispatch inWalletPaymentPickMethodScreen, after Continue button pressHow to test
With the io-dev-api-server, start a new payment flow from the Profile > Playgrounds > New Wallet > Payment screen. With reactotron, check that the transaction creation request is dispatched before the PSP selection screen.